Add GSSP fallback implementation #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
4 times, most recently
from
4fd3cd8 to
bd0cec2
Compare
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
4 times, most recently
from
fd31d57 to
feab5b3
Compare
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
from
feab5b3 to
3767e04
Compare
parijke
approved these changes
May 14, 2025
src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Entity/SecondFactor.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupGateway/SecondFactorOnlyBundle/Service/Gateway/RespondService.php
Outdated
Show resolved
Hide resolved
This will allow the token fallback without the need of an entity.
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
from
d31ca41 to
39aafbe
Compare
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
from
5b7d893 to
e9464b4
Compare
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
2 times, most recently
from
0403018 to
7e60040
Compare
pablothedude
changed the title
parijke
reviewed
May 26, 2025
There was a problem hiding this comment.
We (minvws) normally disapprove PR's this big. Maximum is around 400 changes. I also see some style improvements, but we agreed that a linter should handle that.
Important: if you use mockery shouldReceive without once(), you may have passing tests with false positives.
src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Entity/DoctrineSecondFactorRepository.php
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/CookieService.php
Outdated
Show resolved
Hide resolved
src/Surfnet/StepupGateway/GatewayBundle/Tests/Service/Gateway/RespondServiceTest.php
Show resolved
Hide resolved
...ateway/SecondFactorOnlyBundle/Tests/Service/Gateway/GsspFallback/GsspFallbackServiceTest.php
Show resolved
Hide resolved
...ateway/SecondFactorOnlyBundle/Tests/Service/Gateway/GsspFallback/GsspFallbackServiceTest.php
Show resolved
Hide resolved
I agree to keep PR's as small as possible but as long as they are atomic and it adds a single functionality that would be perfectly fine. |
This is done for the functional testing setup
pablothedude
force-pushed
the
feature/add-azure-mfa-registration-fallback
branch
from
7e60040 to
fd77127
Compare
This was referenced May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#441
#442
#443